Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33549 )
Change subject: sb/intel/bd82x6x/lpc: Setup default LPC decode ranges
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/33549/4/src/mainboard/roda/rv11/var...
File src/mainboard/roda/rv11/variants/rw11/romstage.c:
https://review.coreboot.org/c/coreboot/+/33549/4/src/mainboard/roda/rv11/var...
PS4, Line 35: COMB_LPC_EN
if we always enable com B, this could also be dropped […]
Done
https://review.coreboot.org/c/coreboot/+/33549/4/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/early_pch.c:
https://review.coreboot.org/c/coreboot/+/33549/4/src/southbridge/intel/bd82x...
PS4, Line 264: | KBC_LPC_EN | MC_LPC_EN;
| LPT_LPC_EN and | COMB_LPC_EN ? […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33549
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifeb5a862e56f415aa847d0118a33a31537ab8037
Gerrit-Change-Number: 33549
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 13 Oct 2019 13:45:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment