Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49213 )
Change subject: soc/intel/common/uart: Use simple(_s_) variants of PCI functions
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
I'd rather take approach of dropping __SIMPLE_DEVICE__ entirely and always pass struct device *.
I was trying to avoid the usage of struct device * where possible so that it doesn't pull in the references to all other devices unnecessarily in early stages.
If you skip walking the devicetree and use alias instead, you can also remove all the tree topology aka links for the early stages. I have such commit somewhere locally.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49213
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I344037828118572ae5eb27c82c496d5e7a508a53
Gerrit-Change-Number: 49213
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 Jan 2021 08:20:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment