Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34662 )
Change subject: Documentation/binaries: Add AMD FSP documentation
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34662/8/Documentation/binaries/amd/...
File Documentation/binaries/amd/AMD_FSP_family_17h.md:
https://review.coreboot.org/c/coreboot/+/34662/8/Documentation/binaries/amd/...
PS8, Line 5: Starting with Family 17h, AMD is AGESA version 9. However, it is currently \
no need for \ at end of line
https://review.coreboot.org/c/coreboot/+/34662/8/Documentation/binaries/amd/...
PS8, Line 34: As a consequence, there’s no need of FSP-T. Very little of original \
add 3 spaces at the beginning of each line to place the block inside the option list
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59a5d34df93cd0ff647e2ccfdbf8700b4df00a59
Gerrit-Change-Number: 34662
Gerrit-PatchSet: 8
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kerry Brown
kerry.brown@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 22 Aug 2019 06:44:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment