Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31052 )
Change subject: util/superiotool: detect Fintek F81866, F8196*
......................................................................
Patch Set 2: Code-Review+1
F8196* detection is not actually tested. If that's a problem, I'll remove it and leave just the F81866 ID.
So all F8196* chips share the same ID, right? If they all share one ID (I wonder if those are the same silicon, but different packages), then I'm ok with the patch in its current state.
It would be nice if you'd add the registers and their defaults in a follow-up patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31052
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7210e1523a188a8593cd03547bb0c95cd3e7aa39
Gerrit-Change-Number: 31052
Gerrit-PatchSet: 2
Gerrit-Owner: Kyle Stevenson
kstevenson@comqi.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyle Stevenson
kstevenson@comqi.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 24 Jan 2019 02:20:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment