[coreboot-gerrit] Change in ...coreboot[master]: vboot: refactor OPROM code

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32262 )

Change subject: vboot: refactor OPROM code
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig 
File src/security/vboot/Kconfig:

https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig@180 
PS7, Line 180: and any other native display initialization code is not run
> I guess it would be best to make MUST_REQUEST_DISPLAY the default

I've thought about that too, or getting rid of the option entirely, I think my remaining concern was that we'd then forget to disable it for devices that don't have a display at all. The problem with defaults is that nobody would ever override them unless there's a visible issue. With the way it's done here, it's unset by default but you'll realize very quickly if you need to set it because of the assertion in display_init_required().