Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39179 )
Change subject: mb/*/Kconfig: Factor out MAINBOARD_VENDOR
......................................................................
Patch Set 1:
Patch Set 1:
I don't mind the unification. But first, should we discuss why it should
have a prompt? I assumed that this is tied to the code, and only SMBIOS
data etc. can be overridden.
I don't really mind, as long as this gets merged someday. After all, adding or removing the prompt is now a single line change :P
I think the prompt got there for stuff like Google boards: their coreboot "vendor" is Google, but the boards themselves are manufactured by someone else (Compal, Wistron, Quanta, Pegatron...) for yet another somebody else (Acer, Asus, Dell, HP...). The ability to override the vendor string probably comes from that, I guess.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39179
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03eec7c13d18b42e3c56fb1a43dc665d5dbd1145
Gerrit-Change-Number: 39179
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 01 Mar 2020 16:11:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment