Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47697 )
Change subject: mb/google/octopus: fix droid lte sku load specific wifi sar value
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47697/2/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/bobba/variant.c:
https://review.coreboot.org/c/coreboot/+/47697/2/src/mainboard/google/octopu...
PS2, Line 24: if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36 || sku_id == 37 ||
: sku_id == 38 || sku_id == 39 || sku_id == 40 || sku_id == 41 || sku_id == 42 ||
: sku_id == 43 || sku_id == 44)
Looking at the continuity in the sku_id, can be simplified as […]
done, thanks for suggestion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47697
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55dda85b8f3e664d97834b712a2c6a48d1434010
Gerrit-Change-Number: 47697
Gerrit-PatchSet: 3
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 19 Nov 2020 00:47:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment