[coreboot-gerrit] Change in ...coreboot[master]: soc/apl: Add eMMC, SD-Card and SDIO config options

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32049 )

Change subject: soc/apl: Add eMMC, SD-Card and SDIO config options
......................................................................

Patch Set 3:

(4 comments)

https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c 
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c@713 
PS3, Line 713: 	silconfig->eMMCEnabled = cfg->emmc_enabled;
already set by parse_devicetree()

https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c@729 
PS3, Line 729: 	silconfig->SdcardEnabled = cfg->sdcard_enabled;
already set by parse_devicetree()

https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c@743 
PS3, Line 743: 	silconfig->SdioEnabled = cfg->sdio_enabled;
already set by parse_devicetree()

https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c@771 
PS3, Line 771: 
unrelated