Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75367?usp=email )
(
3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/siemens/{mc_apl2,mc_apl5,mc_apl6}: Use SSD type for SATA ports ......................................................................
mb/siemens/{mc_apl2,mc_apl5,mc_apl6}: Use SSD type for SATA ports
There are only SSD connected to SATA ports on this mainboard. To prevent misbehavior, set the correct hard drive type for enabled SATA ports.
BUG=none TEST=Boot into OS and check the stability of the SSD
Change-Id: I2c2b0548865e87859a1d742295e09a731bfb3f76 Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/75367 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jan Samek jan.samek@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb 3 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Jan Samek: Looks good to me, approved
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb index 2b2c32d..1291497 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb @@ -69,6 +69,8 @@ device pci 12.0 on # - SATA register "SataPortsEnable[0]" = "1" register "SataPortsEnable[1]" = "1" + register "sata_ports_ssd[0]" = "1" + register "sata_ports_ssd[1]" = "1" register "DisableSataSalpSupport" = "1" register "sata_speed" = "SATA_GEN2" end diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb index 15ca3f1..b308ab2 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb @@ -69,6 +69,8 @@ device pci 12.0 on # - SATA register "SataPortsEnable[0]" = "1" register "SataPortsEnable[1]" = "1" + register "sata_ports_ssd[0]" = "1" + register "sata_ports_ssd[1]" = "1" register "DisableSataSalpSupport" = "1" register "sata_speed" = "SATA_GEN2" end diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb index 3c907e3..1885e81 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb @@ -40,6 +40,8 @@ device pci 12.0 on # - SATA register "SataPortsEnable[0]" = "1" register "SataPortsEnable[1]" = "1" + register "sata_ports_ssd[0]" = "1" + register "sata_ports_ssd[1]" = "1" register "DisableSataSalpSupport" = "1" register "sata_speed" = "SATA_GEN2" end