Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41049 )
Change subject: nb/intel/i440bx: DSDT upgrade ......................................................................
Patch Set 1:
(3 comments)
Does the new file need to be included somewhere?
https://review.coreboot.org/c/coreboot/+/41049/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41049/1//COMMIT_MSG@7 PS1, Line 7: nb/intel/i440bx: DSDT upgrade
nb/intel/i440bx: Upgrade DSDT
nb/intel/i440bx: Refactor DSDT
https://review.coreboot.org/c/coreboot/+/41049/1//COMMIT_MSG@15 PS1, Line 15: now it is between TOM and (4GB - CONFIG_ROM_SIZE). Three separate commits would be nice.
https://review.coreboot.org/c/coreboot/+/41049/1/src/northbridge/intel/i440b... File src/northbridge/intel/i440bx/acpi/i440bx.asl:
https://review.coreboot.org/c/coreboot/+/41049/1/src/northbridge/intel/i440b... PS1, Line 32: CONFIG_ROM_SIZE, // Address Length Is it a Gerrit bug, showing the misalignment of the second comment?