[coreboot-gerrit] Change in coreboot[master]: sb/intel/bd82x6x/usb_xhci: Lock OC config and do refactoring

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34335 )

Change subject: sb/intel/bd82x6x/usb_xhci: Lock OC config and do refactoring
......................................................................

Patch Set 5:

(4 comments)

https://review.coreboot.org/c/coreboot/+/34335/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34335/3//COMMIT_MSG@7 
PS3, Line 7: refactoring
> *do refactoring* or *refactor code*

Done

https://review.coreboot.org/c/coreboot/+/34335/3//COMMIT_MSG@19 
PS3, Line 19: Untested
> Can the successful locking be verified from the OS?

yes, you could try to write the register and change it contents.

https://review.coreboot.org/c/coreboot/+/34335/3/src/southbridge/intel/bd82x... 
File src/southbridge/intel/bd82x6x/usb_xhci.c:

https://review.coreboot.org/c/coreboot/+/34335/3/src/southbridge/intel/bd82x... 
PS3, Line 52: XHCC+2
> Spaces around the operator? […]

Done

https://review.coreboot.org/c/coreboot/+/34335/3/src/southbridge/intel/bd82x... 
PS3, Line 55: XHCC+2
> Ditto.

Done