Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Mathew King, Matt DeVillier, Tim Wawrzynczak. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51082 )
Change subject: RFC: mb/google - add 3 new mainboard choice methods ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: I feel this is really convoluted and makes the Kconfig.name files super hard to read. I'm also not sure we need 3 different extra modes... is there really enough demand for a by-SoC method (especially considering that baseboards usually map to SoCs almost 1-to-1)? And by-marketing-name is basically the same as by-vendor except that all vendors are thrown together into one huge (unordered) list, right? Who would ever want to use that? Considering that the vendor name is normally part of the marketing name, that seems like a reasonable first-level hierarchy, so by-vendor would just seem to always be the preferable method to me.
I'd guess by vendor is the only really needed one here, and if we want that aren't there much simpler and less convoluted ways to achieve that? Just make a new src/mainboard/acer/chromeos/Kconfig.name that has entries like this:
config BOARD_ACER_CHROMEOS_ALEENA1 bool "Acer Chromebook 315 (CB315-2H) (GOOGLE_ALEENA)" select BOARD_GOOGLE_ALEENA select SOMETHING_THAT_WILL_FORCE_THE_MAINBOARD_VENDOR_KCONFIG_TO_GOOGLE
I think that's about the same amount of stuff you need to add for every single board, but it doesn't require all these new choices and depends. And you can order them alphabetically, and they will actually show up under the expected mainboard vendor instead of having to navigate through "Google"->"by vendor"->"<vendor>" which I think would be a plus.