[coreboot-gerrit] Change in coreboot[master]: drivers/wifi/generic: Add support for generating SMBIOS data

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46034 )

Change subject: drivers/wifi/generic: Add support for generating SMBIOS data
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46034/2/src/drivers/wifi/generic/ge... 
File src/drivers/wifi/generic/generic.c:

https://review.coreboot.org/c/coreboot/+/46034/2/src/drivers/wifi/generic/ge... 
PS2, Line 293: #if CONFIG(GENERATE_SMBIOS_TABLES)
> suggestion: instead of using #if CONFIG here, you could just add the function, and have it return im […]

Actually, `get_smbios_data` structure member definition itself is guarded using #if CONFIG(GENERATE_SMBIOS_TABLES). So, I think we will need the same guard here.