Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37921 )
Change subject: mainboard/google/hatch: Move gpio GPP_C* NC down into baseboard ......................................................................
Patch Set 4:
(9 comments)
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... PS4, Line 144: * : * TODO: Driver doesn't use this pin as of now. In case driver starts : * using this pin, expose this pin to driver. : */ Looks like this comment got lost when moving the config to variant. I think it would be good to still keep it in the variant.
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/gpio.c:
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... PS4, Line 95: PAD_CFG_GPI(GPP_C20, NONE, DEEP), This is still required since there is no override for early_gpio_table.
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/hatch/gpio.c:
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... PS4, Line 64: PAD_CFG_GPI(GPP_C20, NONE, DEEP), This cannot be removed.
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/gpio.c:
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... PS4, Line 87: PAD_CFG_GPI(GPP_C20, NONE, DEEP), This cannot be removed.
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/gpio.c:
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... PS4, Line 204: PAD_CFG_GPI(GPP_C20, NONE, DEEP), This cannot be removed.
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... PS4, Line 111: PAD_CFG_GPI(GPP_C20, NONE, DEEP), This cannot be removed.
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/mushu/gpio.c:
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... PS4, Line 64: PAD_CFG_GPI(GPP_C20, NONE, DEEP), This cannot be removed.
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/gpio.c:
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... PS4, Line 41: PAD_CFG_GPI(GPP_C20, NONE, DEEP), This cannot be removed.
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/stryke/gpio.c:
https://review.coreboot.org/c/coreboot/+/37921/4/src/mainboard/google/hatch/... PS4, Line 81: PAD_CFG_GPI(GPP_C20, NONE, DEEP), This cannot be removed.