Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46511 )
Change subject: security/vboot: Add new TPM NVRAM index MRC_RW_HASH_NV_INDEX
......................................................................
Patch Set 13: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46511/13/src/security/vboot/secdata...
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/46511/13/src/security/vboot/secdata...
PS13, Line 324: * our hands.
Can you also remove all this TPM1 stuff concerning the MRC hash, now that we have forbidden that anyway (can be a later patch if you want)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46511
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2de3c23aa56d3b576ca54dbd85c75e5b80199560
Gerrit-Change-Number: 46511
Gerrit-PatchSet: 13
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 20 Oct 2020 00:10:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment