[coreboot-gerrit] Change in coreboot[master]: util/inteltool: add many missing registers for skl/kbl

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )

Change subject: util/inteltool: add many missing registers for skl/kbl
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/apic.c 
File util/inteltool/apic.c:

PS6:
> i think the number of type casts on apicbase can be reduced when declaring it as volatile const u32  […]

just using the read8/16/32 functions would also make this nicer

https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/apic.c@33 
PS6, Line 33: 	*((volatile u32 *)(ioapic_base)) = reg;
use read32 from arch/mmio.h here instead to avoid having so much pointer type casts?