Hello Tim Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/38458
to review the following change.
Change subject: mainboard/google/puff: update SATA strength ......................................................................
mainboard/google/puff: update SATA strength
Base on SATA SI report to fine tune the strength for port 1.
BRANCH=none BUG=b:147351936 TEST=build and test SATA port works fine.
Change-Id: Ib82b7e5df32b4ce794682781f33c44dfeb6e68bf Signed-off-by: Tim Chen tim-chen@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/38458/1
diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index e3ccc61..bddc39e 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -122,6 +122,10 @@ # GPIO for SD card detect register "sdcard_cd_gpio" = "vSD3_CD_B"
+ # SATA port 1 Gen3 Strength + register "PchSataHsioTxGen3DeEmphEnable[1]" = "1" + register "PchSataHsioTxGen3DeEmph[1]" = "0x20" + device domain 0 on device pci 14.0 on chip drivers/usb/acpi