[coreboot-gerrit] [S] Change in coreboot[main]: soc/mediatek/common/dp: Add read/write APIs for DP Phy register

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85914?usp=email )

Change subject: soc/mediatek/common/dp: Add read/write APIs for DP Phy register
......................................................................

Patch Set 2:

(3 comments)

File src/soc/mediatek/common/dp/dptx_hal_common.c:

https://review.coreboot.org/c/coreboot/+/85914/comment/5ee4690e_d91c23ea?usp... :
PS1, Line 73: 	if (!mtk_dp->phy_regs) {
> Same here. Use an assertion.

Done

https://review.coreboot.org/c/coreboot/+/85914/comment/2dc1adc2_010a12f7?usp... :
PS1, Line 78: if (offset % 4 != 0 || offset > REG_OFFSET_LIMIT) {
            : 		printk(BIOS_ERR, "[%s] invalid offset %#x for reg %p\n",
            : 		       __func__, offset, mtk_dp->regs);
            : 		return 0;
            : 	}
> Although existing code is also written this way, I think this should be assertions (instead of run-t […]

Done

https://review.coreboot.org/c/coreboot/+/85914/comment/a54be643_4e30b495?usp... :
PS1, Line 120: /*
             : 	 * TODO: modify to clrsetbits32(addr, mask, val);
             : 	 * There is asserion error when testing assert((val & mask) == val).
             : 	 */
> I checked all the `mtk_dp_phy_mask` callers, and think the assertion is always valid. […]

Done