17 Aug
2020
17 Aug
'20
6:32 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37392 )
Change subject: cpu/x86/smm/smm_stub: Add x86_64 support ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37392/7/src/cpu/x86/smm/smm_stub.S File src/cpu/x86/smm/smm_stub.S:
https://review.coreboot.org/c/coreboot/+/37392/7/src/cpu/x86/smm/smm_stub.S@... PS7, Line 190: #include <cpu/x86/64bit/entry64.inc>
Copying the PGTBL won't work as the pointers to the next level will be incorrect. […]
using page tables other than CONFIG_ARCH_X86_64_PGTBL_LOC sounds like a good idea. CB:30119 could be used to generate fine grained tables for SMM or ramstage.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37392
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26300492e4be62ddd5d80525022c758a019d63a1
Gerrit-Change-Number: 37392
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Eugene Myers cedarhouse1@comcast.net
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: ron minnich rminnich@gmail.com
Gerrit-Comment-Date: Mon, 17 Aug 2020 06:32:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eugene Myers cedarhouse1@comcast.net
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment