[coreboot-gerrit] Change in coreboot[master]: Documentation: Add guidelines for new mainboard ports

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34632 )

Change subject: Documentation: Add guidelines for new mainboard ports
......................................................................

Patch Set 6: Code-Review+1

(4 comments)

https://review.coreboot.org/c/coreboot/+/34632/6/Documentation/getting_start... 
File Documentation/getting_started/mainboard_template.md:

https://review.coreboot.org/c/coreboot/+/34632/6/Documentation/getting_start... 
PS6, Line 72: * Does it support RS232 serial?
Maybe add something to describe the voltage level if a TTL UART is available?

https://review.coreboot.org/c/coreboot/+/34632/6/Documentation/getting_start... 
File Documentation/getting_started/new_mainboard_ports.md:

https://review.coreboot.org/c/coreboot/+/34632/6/Documentation/getting_start... 
PS6, Line 30:  
Maybe add "if available" here avoid confusion?

https://review.coreboot.org/c/coreboot/+/34632/6/Documentation/getting_start... 
PS6, Line 35: Some boards have two SPI flashes for ME and BIOS.
Maybe more clear:
"Some boards have two SPI flashes, one for ME and a second for BIOS."

https://review.coreboot.org/c/coreboot/+/34632/6/Documentation/getting_start... 
PS6, Line 37: It 
It is