Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47614 )
Change subject: nb/intel/sandybridge: Use one sequence for write leveling
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47614/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/47614/1/src/northbridge/intel/sandy...
PS1, Line 1725: if (ctrl->rank_mirror[channel][slotrank])
: ddr3_mirror_mrreg(&bank, &mr1reg);
This looks like a functional difference. […]
It isn't, but I'll add some logic lubricant. Hint: `ddr3_mirror_mrreg` was created in the immediately preceding commit
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65ca1aa32cdb177d2a9e27c3b02e74ac0c882794
Gerrit-Change-Number: 47614
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 14:49:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment