Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36808 )
Change subject: security/vboot: Remove flags from struct vboot_working_data ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36808/1/src/security/vboot/bootmode... File src/security/vboot/bootmode.c:
https://review.coreboot.org/c/coreboot/+/36808/1/src/security/vboot/bootmode... PS1, Line 151: cbmem_possibly_online()
If this function is executed after verstage, but before cbmem comes up, I think it will always retur […]
vboot_logic_executed() should give a correct answer at all times, it shouldn't need to be predicated by something else. I think we can just get rid of vboot_possibly_executed(), it serves no purpose that vboot_logic_executed() doesn't serve better. (It was probably added for better compile-time elimination before CB:32716 made vboot_logic_executed() capable of that directly.)