Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34564 )
Change subject: mb/up/squared: Fill LPDDR4 dimm info ......................................................................
Patch Set 4:
(6 comments)
according to accumulate_channel_memory() the memory config should be as follows
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... File src/mainboard/up/squared/romstage.c:
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... PS4, Line 39: .ch1_rank_density = LP4_8Gb_DENSITY, ch1_rank_density = 0
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... PS4, Line 46: .ch0_rank_density = LP4_16Gb_DENSITY, LP4_8Gb_DENSITY
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... PS4, Line 47: .ch1_rank_density = LP4_16Gb_DENSITY, LP4_8Gb_DENSITY
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... PS4, Line 48: .ch0_dual_rank = 1, = 0
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... PS4, Line 49: .ch1_dual_rank = 1, = 0
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... PS4, Line 54: LP4_32Gb_DENSITY LP4_16Gb_DENSITY