build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39277 )
Change subject: Inicial device tree for Microtech etabpro Platform Intel GLK Tablet with the stylus and attachable keyboard ......................................................................
Patch Set 1:
(67 comments)
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... File src/mainboard/microtech/etabpro/gpio.c:
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 34: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_8, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_CLK_VNN */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 35: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_9, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA0_VNN */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 36: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_10, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA1_VNN */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 37: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_11, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA2_VNN */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 38: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_12, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA3_VNN */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 39: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_13, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA4_VNN */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 40: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_14, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA5_VNN */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 41: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_15, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA6_VNN */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 42: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_16, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA7_VNN */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 43: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_17, 1, DEEP, UP_20K, TxDRxE, SAME),/*Ec-to-SOC CS Wake */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 44: PAD_CFG_GPI_APIC_IOS(GPIO_18, UP_20K, DEEP, LEVEL, NONE, IGNORE, SAME),/* Touch Pad Interrupt */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 45: PAD_CFG_GPI_APIC_IOS(GPIO_19, UP_20K, DEEP, EDGE_SINGLE, NONE, TxDRxE, SAME),/*PMIC Interrupt*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 46: PAD_CFG_GPI_APIC_IOS(GPIO_20, UP_20K, DEEP, LEVEL, INVERT, IGNORE, SAME),/* Audio Codec Interrupt*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 51: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_25, 1, DEEP, UP_20K, TxLASTRxE, SAME),/*WWAN /RF_KILL_GPS*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 52: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_26, UP_20K, DEEP, NF2, HIZCRx1, DISPUPD),/* NFC Interrupt */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 53: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_27, 1, DEEP, NONE, IGNORE, DISPUPD),/* RF_KILL_WiFi/WiFi_Disable */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 54: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_28, 1, DEEP, UP_20K, TxLASTRxE, DISPUPD),/* RF_KILL_BT/BT_Disable */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 55: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_29, 1, DEEP, UP_20K, HIZCRx0, DISPUPD),/* Codec Power Down: Output/ISH_GPIO_3*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 63: PAD_CFG_GPI_SCI_IOS(GPIO_37, UP_20K, DEEP, EDGE_SINGLE, INVERT, IGNORE, SAME),/*Runtime SCI */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 64: PAD_CFG_GPI_SCI_IOS(GPIO_38, UP_20K, DEEP, EDGE_SINGLE, INVERT, IGNORE, SAME),/*Wake SCI */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 65: PAD_CFG_GPI_APIC_IOS(GPIO_39, DN_20K, DEEP, LEVEL, NONE, IGNORE, SAME),/* Finger Print Sensor Interrupt (DRDY) */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 66: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_40, UP_20K, DEEP, NF6),/*IERR (USB Camera Power Enable)*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 67: PAD_CFG_GPI_SMI_IOS(GPIO_41, UP_20K, DEEP, EDGE_SINGLE, NONE, IGNORE, SAME),/*SOC_EXTSMI_N */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 72: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_46, UP_20K, DEEP, NF1, HIZCRx1, SAME), /* DSI_I2C_SDA */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 73: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_47, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* DSI_I2C_SCL */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 76: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_50, UP_2K, DEEP, NF1, HIZCRx1, ENPU), /* LPSS_I2C0_SDA - Audio Codec*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 77: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_51, UP_2K, DEEP, NF1, HIZCRx1, ENPU), /* LPSS_I2C0_SCL - Audio Codec */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 78: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_52, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* LPSS_I2C1_SDA - NFC */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 79: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_53, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* LPSS_I2C1_SCL - NFC */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 82: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_56, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/* I2C3-SDA - DBG (PSS, SINAI2, MIPI) */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 83: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_57, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/*I2C3-SCL - DBG (PSS, SINAI2, MIPI) */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 84: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_58, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/*I2C4-SDA - Touch Pad*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 85: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_59, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/*I2C4-SCL - Touch Pad*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 86: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_60, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD),/* UART0-RXD - M.2dGNSS */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 87: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_61, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD),/* UART0-TXD - M.2dGNSS */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 88: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_62, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD),/* UART0-RTS_B - M.2 dGNSS */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 89: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_63, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD),/* UART0-CTS_B - M.2 dGNSS */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 90: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_64, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD),/*LPSS_UART2_RXD*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 91: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_65, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD),/*LPSS_UART2_TXD*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 92: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_66, 1, DEEP, UP_20K, TxDRxE, DISPUPD),/*RF_KILL_WWAN */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 106: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_213, 1, DEEP, NONE, HIZCRx0, SAME),/*DNX LED - CSE owned*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 123: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_90, NATIVE, DEEP, NF1),/*Function 1: FST SPI Boot Flash CS*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 138: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_105, 0, DEEP, NONE, Tx0RxDCRx0, SAME),/*x4 Slot-2 Reset*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 143: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_110, UP_20K, DEEP, NF2, HIZCRx1, ENPU),/*LPSS_I2C5_SDA*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 144: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_111, UP_20K, DEEP, NF2, HIZCRx1, ENPU),/*LPSS_I2C5_SCL*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 145: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_112, UP_20K, DEEP, NF2, HIZCRx1, ENPU),/*LPSS_I2C6_SDA*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 146: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_113, UP_20K, DEEP, NF2, HIZCRx1, ENPU),/*LPSS_I2C6_SCL*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 147: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_114, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/*LPSS_I2C7_SDA*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 148: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_115, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/*LPSS_I2C7_SCL*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 167: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_134, 1, DEEP, UP_20K, IGNORE, SAME),/*Slot-1 Power Enable*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 168: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_135, 1, DEEP, UP_20K, IGNORE, SAME),/*Slot-2 Power Enable*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 169: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_136, 1, DEEP, NONE, Tx0RxDCRx0, SAME),/*DGPU Power Select*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 171: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_138, UP_20K, DEEP, NF2, HIZCRx1, DISPUPD),/*SATA_GP0 (DC RTD3 need)*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 172: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_139, UP_20K, DEEP, NF2, TxLASTRxE, DISPUPD),/*SATA_GP1 (ZPODD_DEV_DET)*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 174: PAD_CFG_NF_IOSSTATE(GPIO_141, UP_20K, DEEP, NF5, HIZCRx1),/*SATA_DEVSLP1 (ZPODD DEV ATN)*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 180: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_157, 1, DEEP, UP_20K, IGNORE, SAME),/*WWAN_Reset/dGPS Reset*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 183: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_160, 0, DEEP, UP_20K, IGNORE, SAME),/*SD_MODE for spk*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 184: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_161, 1, DEEP, UP_20K, IGNORE, SAME),/*Touch panel reset*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 185: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_162, DN_20K, DEEP, NF1, HIZCRx1, SAME),/*AVS_I2S1_BCLK*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 186: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_163, DN_20K, DEEP, NF1, HIZCRx1, SAME),/*AVS_I2S1_WS_SYNC*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 187: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 1, DEEP, NONE, Tx0RxDCRx0, SAME),/*Touch Panel Power Enable*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 192: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_166, DN_20K, DEEP, NF2, HIZCRx1, SAME),/*AVS_I2S2_BCLK*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 193: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_167, DN_20K, DEEP, NF2, HIZCRx1, SAME),/*AVS_I2S2_WS_SYNC*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 194: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_168, DN_20K, DEEP, NF2, HIZCRx1, SAME),/* AVS_I2S2_SDI*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 196: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_170, DN_20K, DEEP, NF2, HIZCRx1, SAME),/*AVS_I2S1_MCLK*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 208: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_179, DN_20K, DEEP, NF1, HIZCRx0, DISPUPD),/*SDCARD_CLK*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39277/1/src/mainboard/microtech/eta... PS1, Line 214: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_185, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD),/*SDCARD_CMD*/ line over 96 characters