Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45578 )
Change subject: mb/hp: Add HP EliteBook Folio 9480m ......................................................................
Patch Set 6:
(7 comments)
https://review.coreboot.org/c/coreboot/+/45578/5/Documentation/mainboard/hp/... File Documentation/mainboard/hp/9480m.md:
PS5:
This file should at least be named `folio_9480m. […]
Done
https://review.coreboot.org/c/coreboot/+/45578/5/Documentation/mainboard/hp/... File Documentation/mainboard/hp/folio_9480m.md:
https://review.coreboot.org/c/coreboot/+/45578/5/Documentation/mainboard/hp/... PS5, Line 38: Done
https://review.coreboot.org/c/coreboot/+/45578/5/Documentation/mainboard/hp/... PS5, Line 42: Done
https://review.coreboot.org/c/coreboot/+/45578/5/Documentation/mainboard/hp/... PS5, Line 110: Done
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... File src/mainboard/hp/folio_9480m/Kconfig:
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... PS5, Line 5: need
needs
Done
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... File src/mainboard/hp/folio_9480m/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... PS5, Line 8: 0x02, /* DSDT revision: ACPI 2.0 and up */
ACPI_DSDT_REV_2, […]
Done
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... File src/mainboard/hp/folio_9480m/gpio.c:
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... PS5, Line 6: =
nit: add another space before the `=` for entries 0 to 9, for alignment purposes
Done