[coreboot-gerrit] [S] Change in coreboot[master]: lenovo/x230: introduce FHD variant

[Aleksei Kharlamov (Code Review)]

Attention is currently required from: Alexander Couzens, Angel Pons, Charles Moyes, Felix Singer, Kilian Neuner, Nico Huber, Paul Menzel, Xue Yao.

Aleksei Kharlamov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950?usp=email )

Change subject: lenovo/x230: introduce FHD variant
......................................................................

Patch Set 22:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/28950/comment/92435b48_4d82b663 :
PS22, Line 18: brightness controls to work out of the box.
> This seems misleading. Yes, it "allows" things to work OOB. But it […]

I have bought another type of kit off aliexpress where instead of tapping into the original screen interface and "proxying" the brightness values to the eDP panel, a USB HID device is exposed into the system.

But what do you understand under "firmware modifications". What firmware do you have in mind? Isn't coreboot itself being the firmware in this case? Ir are you referring to vbt?