Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18498 )
Change subject: libpayload: Improve rtc functions
......................................................................
Patch Set 5: Code-Review+2
One nit, there was a comment
"If one branch has braces all should have them."
not sure why I marked it resolved. I also wonder now why checkpatch
doesn't complain?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/18498
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id773c33e228973e190a7e14c3d11979678b1a619
Gerrit-Change-Number: 18498
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Sun, 08 Mar 2020 15:39:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment