[coreboot-gerrit] Change in coreboot[master]: superio/aspeed/ast2400: Add AST2500 support

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37641 )

Change subject: superio/aspeed/ast2400: Add AST2500 support
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37641/5/src/superio/aspeed/ast2400/... 
File src/superio/aspeed/ast2400/superio.c:

https://review.coreboot.org/c/coreboot/+/37641/5/src/superio/aspeed/ast2400/... 
PS5, Line 112: pnp_dev_info[5].function = -1;
             : 		pnp_dev_info[6].function = -1;
i'd prefer iteration over the array elements and matching on the defines assigned to .function instead of hoping that the offsets won't change when the code gets some refactoring.
also assigning a negative number to an unsigned variable is a bad idea; I'd suggest rebasing this onto 37741 and assign PNP_SKIP_FUNCTION to .function instead