Attention is currently required from: Angel Pons. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55198 )
Change subject: [RFC,WIP] cpu/x86/lapic: Evaluate x2apic_mode just once ......................................................................
Patch Set 14:
(3 comments)
Patchset:
PS12:
Breaks booting with X2APIC_RUNTIME on Haswell (X2APIC_ONLY didn't work before).
wip
File src/cpu/x86/lapic/lapic.c:
https://review.coreboot.org/c/coreboot/+/55198/comment/20cb6936_61f5cf22 PS12, Line 12: int x2apic_mode_enabled; Needs initialisation for ENV_SMM too.
File src/include/cpu/x86/lapic.h:
https://review.coreboot.org/c/coreboot/+/55198/comment/c0702972_1a0811c1 PS12, Line 84: return x2apic_mode_enabled;
I think it makes sense to return false when `is_x2apic_mode()` is called before `enable_lapic()` has […]
My objective is to evaluate is_x2apic_mode() as a constant in lapic.h accessor functions. The return value of false would be equally wrong there, if enable_lapic() was not yet called.