Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41384 )
Change subject: device/pci_device: Add notion of "hidden" PCI devices ......................................................................
Patch Set 8: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/41384/7/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/41384/7/src/device/pci_device.c@795 PS7, Line 795: hidden_pci_dev_ops
That would also imply pci_bus_ops_pci on line 773 isn't necessary either.
Looks like it. It's also odd that it initializes only one out of two pointers explicitly to NULL. Probably some very stale piece of code.
https://review.coreboot.org/c/coreboot/+/41384/7/src/device/pci_device.c@122... PS7, Line 1223: * ID as if there were no device there (0xffffffff).
Fair point. In this case, I meant the semantics of using the 'hidden' keyword in the devicetree. […]
Understood. But it seems a bit too limited. Would it suffice to say that "The device' config space can still be accessed somehow."? I guess that's the point to keep a hidden device on the PCI bus?