Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38189 )
Change subject: drivers/elog,pc80: Move cmos_post_log()
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38189/5/src/drivers/elog/elog.c
File src/drivers/elog/elog.c:
https://review.coreboot.org/c/coreboot/+/38189/5/src/drivers/elog/elog.c@779
PS5, Line 779: /* Always zero with !CMOS_POST_EXTRA. */
Is this comment correct with "extra" uninitialized at the top and not assigned anything in cmos_post_previous with !CONFIG_POST_EXTRA?
https://review.coreboot.org/c/coreboot/+/38189/5/src/drivers/pc80/rtc/post.c
File src/drivers/pc80/rtc/post.c:
https://review.coreboot.org/c/coreboot/+/38189/5/src/drivers/pc80/rtc/post.c...
PS5, Line 23: cmos_post_previous
nit: cmos_post_previous_boot?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98044a28c29a2b1756fb25fb593f505e914a71c0
Gerrit-Change-Number: 38189
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Jan 2020 16:58:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment