Attention is currently required from: Martin Roth, Mathew King, Karthik Ramasubramanian, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52393 )
Change subject: drivers/amd/i2s_machine_dev: Make DMIC select gpio optional ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52393/comment/683e22bf_252ebcb5 PS1, Line 9: hotword detection is always going to be done : using the mic in user-facing camera Why does "hotword detection" matter here? From the bug comments, it looks like the DMIC selection is not required in hardware because kernel driver handles appropriate channel selection in case of multiple DMICs. Is that understanding correct?
File src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c:
https://review.coreboot.org/c/coreboot/+/52393/comment/93acd1b3_55fe4b9d PS1, Line 42: dmic_select_gpio->pin_coun This needs update too: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
We should add some context as to when the dmic_select_gpio would be required.