Yanjie Jiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32666 )
Change subject: mediatek/mt8183: Add md power-off flow
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/32666/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/32666/8//COMMIT_MSG@15
PS8, Line 15: Test=Boots correctly on Kukui, suspend test.
Before it did not suspend or resume correctly?
Yes, will fail suspend/resume.
https://review.coreboot.org/c/coreboot/+/32666/8/src/soc/mediatek/mt8183/md_...
File src/soc/mediatek/mt8183/md_ctrl.c:
https://review.coreboot.org/c/coreboot/+/32666/8/src/soc/mediatek/mt8183/md_...
PS8, Line 26: /* Gating MD clock. */
Remove the dot at the end?
deleted
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32666
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6e11faeb6936a1dd6bbe8b1a8b612446bf51082
Gerrit-Change-Number: 32666
Gerrit-PatchSet: 10
Gerrit-Owner: Yanjie Jiang
yanjie.jiang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: Yanjie Jiang
yanjie.jiang@mediatek.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jul 2019 11:46:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment