John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32189 )
Change subject: ACPI: Add RHSA and ANDD structures for DMAR table
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32189/3/src/arch/x86/acpi.c
File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/32189/3/src/arch/x86/acpi.c@616
PS3, Line 616: oid acpi_dmar_rhsa_fixup(unsigned long base, unsigned long current)
: {
: dmar_rhsa_entry_t *rhsa = (dmar_rhsa_entry_t *)base;
: rhsa->length = current - base;
: }
:
: void acpi_dmar_andd_fixup(unsigned long base, unsigned long current)
: {
: dmar_andd_entry_t *andd = (dmar_andd_entry_t *)base;
: andd->length = current - base;
: }
These structures don't end in variable length lists, so the length […]
Updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I042925a7c03831061870d9bca03f11bf25aeb3e7
Gerrit-Change-Number: 32189
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 25 Apr 2019 17:49:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment