Attention is currently required from: Martin Roth, Maximilian Brune, Philipp Hug, ron minnich.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81425?usp=email )
Change subject: arch/riscv: add Kconfig variable RISCV_SOC_HAS_MENVCFG ......................................................................
Patch Set 1:
(1 comment)
File src/arch/riscv/Kconfig:
https://review.coreboot.org/c/coreboot/+/81425/comment/2aaf9381_7e7ee29d : PS1, Line 112: : # Newer SoC have the menvconfig register. : # Very few SOC do not have this. : # Older SoC, such as the SiFive FU[57]40, that : # do not have this register, should set this : # to n.
I'd rather it not be available as something people can set, why I put it that way.
Setting it as help text is just a common pattern to keep things organized. We have that for some settings even when they are not user configurable. It's just source cosmetics, doesn't say anything should be configurable.
Typically I'd suggest that this text go into a "help" section, but there's no prompt here, so I'm not sure whether or not it matters.
Anyone else have an opinion?
If in doubt, and it makes no technical difference, I lean towards what the author says. (unless the fear is too big, that somebody else could push unnecessary "cleanup"/alignment patches later)