Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46566
to look at the new patch set (#8).
Change subject: mb/google/zork: Add explicit check for non-zero return value of cbi functions ......................................................................
mb/google/zork: Add explicit check for non-zero return value of cbi functions
Since google_chromeec_cbi_get_board_version and google_chromeec_cbi_get_fw_config both call cbi_get_unit32 and return 0 as success. Let's add more readability for the false condition.
BUG=None TEST=check with empty CBI value
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia49ac1ee35302f8f6afe8c0eb8e13afdf36c5b2b --- M src/mainboard/google/zork/variants/baseboard/helpers.c M src/mainboard/google/zork/variants/berknip/gpio.c M src/mainboard/google/zork/variants/dalboz/gpio.c M src/mainboard/google/zork/variants/dirinboz/gpio.c M src/mainboard/google/zork/variants/ezkinil/gpio.c M src/mainboard/google/zork/variants/morphius/gpio.c M src/mainboard/google/zork/variants/trembyle/gpio.c M src/mainboard/google/zork/variants/vilboz/gpio.c M src/mainboard/google/zork/variants/woomax/gpio.c 9 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/46566/8