11 Jan
2019
11 Jan
'19
10:32 p.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30851 )
Change subject: nb/intel/pineview: Move the boilerplate mainboard_romstage_entry ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/30851/2/src/northbridge/intel/pineview/romst... File src/northbridge/intel/pineview/romstage.c:
https://review.coreboot.org/#/c/30851/2/src/northbridge/intel/pineview/romst... PS2, Line 98: timestamp_add_now(TS_BEFORE_INITRAM); This commit of followup, move to ramininit.c
https://review.coreboot.org/#/c/30851/2/src/northbridge/intel/pineview/romst... PS2, Line 105: quick_ram_check(); Move to raminit.c
--
To view, visit https://review.coreboot.org/c/coreboot/+/30851
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33cf1d6a60d272f490f41205ec725dee8b00242b
Gerrit-Change-Number: 30851
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit damien@zamaudio.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Jan 2019 22:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment