Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36943 )
Change subject: WIP: Use binaries from Windows installer directly
......................................................................
Patch Set 4:
Patch Set 3:
Interesting idea, but the tar reader seems to be home-grown, which won't bode well with a format that probably has more variations than there are em100s out there.
I'll worry about that when I see a tar version that causes trouble. So far all systems I have tried worked fine with the system tar. We're somewhat safe here, because we never have to compile this for machines that do not have USB.
--
To view, visit
https://review.coreboot.org/c/em100/+/36943
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: I8c360e96ce42fd78141a1564976454711e20f527
Gerrit-Change-Number: 36943
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 21 Nov 2019 02:08:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment