9 Jan
2023
9 Jan
'23
9:14 p.m.
Attention is currently required from: Matt DeVillier, Elyes Haouas.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64939 )
Change subject: treewide: Remove unused <cpu/amd/msr.h> ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/cpu/amd/smm/smm_init.c:
https://review.coreboot.org/c/coreboot/+/64939/comment/a41cb637_a4ca0d78 PS4, Line 16: SYSCFG_MSR
"cat src/include/cpu/amd/msr. […]
oh, you're right, SYSCFG_MSR is defined in cpu/amd/mtrr.h. seems that i mixed up msr.h and mtrr.h in some spots
--
To view, visit https://review.coreboot.org/c/coreboot/+/64939
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id24a7c7db24f49672df9d5ceefec5b7596f23e09
Gerrit-Change-Number: 64939
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 09 Jan 2023 21:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Elyes Haouas ehaouas@noos.fr
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment