Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32379 )
Change subject: src/mb: Use system_reset() ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
IMHO, I personally find the cf9 reset call names a bit hard to follow.
When I introduced them, I used the names from Intel's documentation. All other names like soft/hard reset, warm/cold reset were already used ambiguously in the tree. So it didn't seem reasonable to reuse any of these. Suggestions for better names are welcome :)
https://review.coreboot.org/#/c/32379/1/src/mainboard/asus/p5qpl-am/romstage... File src/mainboard/asus/p5qpl-am/romstage.c:
https://review.coreboot.org/#/c/32379/1/src/mainboard/asus/p5qpl-am/romstage... PS1, Line 195: system_reset
Looks like it's not the same type of reset. […]
Done