Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36492 )
Change subject: mainboard/google: Move variant_memory_sku() to baseboard/
......................................................................
Patch Set 2:
Patch Set 2:
(1 comment)
Are you abandoning this patchset then?
Well I prefer to go the https://review.coreboot.org/c/coreboot/+/36250 route for the reasons stated above, I think that is what we decided here or have I miss understood? Regardless, I just need a decision so we can keep things moving forwards.
Either;
i) we do this refactor,
ii) just move romstage's,
iii) just create a new board.
I have patches for all these paths up so I just need an actual decision (as in +2's less obviously any technical adjustments) so we can proceed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36492
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41532e3067a989db5776887fac0459a000d07ff0
Gerrit-Change-Number: 36492
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz
djkurtz@google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Comment-Date: Sat, 02 Nov 2019 00:37:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment