Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48571 )
Change subject: soc/intel/skylake: Drop unreferenced devicetree settings
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48571/3/src/soc/intel/skylake/chip....
File src/soc/intel/skylake/chip.h:
https://review.coreboot.org/c/coreboot/+/48571/3/src/soc/intel/skylake/chip....
PS3, Line 311: ApertureSize
Not referenced on Skylake.
Gone.
https://review.coreboot.org/c/coreboot/+/48571/3/src/soc/intel/skylake/chip....
PS3, Line 398: PmConfigPciClockRun
Duplicates `lpc_enable_pci_clk_cntl()` in `soc/intel/common/block/lpc/lpc_lib. […]
Yes, please. Marking this as resolved since this comment doesn't need to block this patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48571
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76aa2327d440394a9176c023bc95fb34e713741e
Gerrit-Change-Number: 48571
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 12 Dec 2020 22:35:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-MessageType: comment