Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47008 )
Change subject: mb/google/asurada: Configure pins mode for SD ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47008/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47008/1//COMMIT_MSG@11 PS1, Line 11: Enable VCC and VCCQ power supply for SD. Either start a new paragraph (by adding a blank line before this), or merge into the previous line.
https://review.coreboot.org/c/coreboot/+/47008/1/src/mainboard/google/asurad... File src/mainboard/google/asurada/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47008/1/src/mainboard/google/asurad... PS1, Line 11: #include <soc/regulator.h> Please sort these.