Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31594 )
Change subject: cpu/x86/smm: Add qemu's SMM-Revision Level ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31594/1/src/cpu/x86/smm/smihandler.c File src/cpu/x86/smm/smihandler.c:
https://review.coreboot.org/#/c/31594/1/src/cpu/x86/smm/smihandler.c@151 PS1, Line 151: switch (smm_revision) { We could also mask bits that don't interest us here. Actually only bits 0..15 state the revision (see SDM vol 3 "34.9 SMM REVISION IDENTIFIER").