Attention is currently required from: Bill XIE, Nico Huber, Arthur Heymans, Alexander Couzens, Patrick Rudolph, Kevin Keijzer.
Kevin Keijzer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51118 )
Change subject: mb/lenovo/x200: Fix docking events
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Ok, I have also bisected the "undock on resume" phenomenon:
72f13e534bed0be4a3bc0999dc2fe772c322114f is the first bad commit
commit 72f13e534bed0be4a3bc0999dc2fe772c322114f
Author: Bill XIE persmule@hardenedlinux.org
Date: Mon Oct 28 00:16:05 2019 +0800
ec/lenovo/h8: Make dock init in ramstage fully mainboard-specific
Discussed in CB:36093, in the past many lenovo boards need to declare
an empty h8_mainboard_init_dock() to satisfy h8.c.
Now the confusing H8_DOCK_EARLY_INIT might be retired, and if a
mainboard needs dock init (done with h8_mainboard_init_dock() in the
past) in ramstage, (discussed in CB:4294 where H8_DOCK_EARLY_INIT is
introduced) it can just do it in its own chip_ops.enable_dev function.
Tested on X200. Testing on other affected targets may be necessary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51118
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I561e7ae81f2e096a091868ce51daa1c8f66af067
Gerrit-Change-Number: 51118
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Keijzer
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Bill XIE
persmule@hardenedlinux.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Comment-Date: Sun, 28 Feb 2021 18:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment