Attention is currently required from: Tarun Tuli, Paul Menzel, Kapil Porwal, Ivy Jian, Eric Lai, Lean Sheng Tan, Ronak Kanabar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74158 )
Change subject: soc/intel/cmn/cpu: API to disable 3-strike Machine Check CAT error ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74158/comment/4f23dc73_e229f58a PS3, Line 7: API to disable 3-strike Machine Check CAT error
Please make it a statement by adding a verb (in imperative mood). […]
Ack
https://review.coreboot.org/c/coreboot/+/74158/comment/9dd79cdc_ddeae851 PS3, Line 8:
Please describe the problem, including what CAT means, and maybe a reference to the documentation of that counter.
Added ample details. there are more material available online that talks about CATERR
https://review.coreboot.org/c/coreboot/+/74158/comment/ad9e34b5_ccfada54 PS3, Line 10: would help
helps
Ack
https://review.coreboot.org/c/coreboot/+/74158/comment/cf8b7330_033a961b PS3, Line 9: This patch prevents the Three Strike Counter from incrementing, : which would help to disable Machine Check Catastrophic error. : It will provide more opportunity to collect more useful CPU : traces for debugging.
Please use the fully allowed text width of 72 characters per line.
Ack
File src/soc/intel/common/block/include/intelblocks/cpulib.h:
https://review.coreboot.org/c/coreboot/+/74158/comment/79ec7cbe_0fa53066 PS3, Line 227: ,
.
Ack
https://review.coreboot.org/c/coreboot/+/74158/comment/39db6324_3247a82a PS3, Line 228: it will help
It helps
Ack