Attention is currently required from: Alexander Couzens, Angel Pons, Leah Rowe.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81016?usp=email )
Change subject: nb/intel/haswell: make IOMMU a runtime option ......................................................................
Patch Set 1:
(16 comments)
File src/mainboard/asrock/b85m_pro4/cmos.layout:
https://review.coreboot.org/c/coreboot/+/81016/comment/689afe0a_823ecd84 : PS1, Line 14: 412 411 is the next available bit
https://review.coreboot.org/c/coreboot/+/81016/comment/482efa15_927c004b : PS1, Line 42: 6 0 Disable : 6 1 Enable Redundant, enum 1 can be used instead
File src/mainboard/asrock/h81m-hds/cmos.layout:
https://review.coreboot.org/c/coreboot/+/81016/comment/fdb31087_29fba546 : PS1, Line 25: 412 1 e 6 iommu 411 is the next available bit
https://review.coreboot.org/c/coreboot/+/81016/comment/5a0ad044_f0116bc2 : PS1, Line 58: 6 0 Disable : 6 1 Enable Enum 1 can be reused
File src/mainboard/google/beltino/cmos.layout:
https://review.coreboot.org/c/coreboot/+/81016/comment/2722c644_566ac4cf : PS1, Line 23: 412 411 is the net available bit
https://review.coreboot.org/c/coreboot/+/81016/comment/005df1a7_9a2a9fe3 : PS1, Line 53: 8 0 Disable : 8 1 Enable Enum 1 can be reused
File src/mainboard/google/slippy/cmos.layout:
https://review.coreboot.org/c/coreboot/+/81016/comment/77592cb0_b30d8b73 : PS1, Line 23: 412 411 is the next available bit
https://review.coreboot.org/c/coreboot/+/81016/comment/ecd5d40a_c6645eba : PS1, Line 53: 0 Disable : 8 1 Enable Enum 1 can be reused
File src/mainboard/intel/baskingridge/cmos.layout:
https://review.coreboot.org/c/coreboot/+/81016/comment/7707c4cf_911944e9 : PS1, Line 22: 412 411 is the next available bit
https://review.coreboot.org/c/coreboot/+/81016/comment/0ae8ce47_99a8840d : PS1, Line 52: 8 0 Disable : 8 1 Enable Enum 1 can be reused
File src/mainboard/lenovo/haswell/cmos.layout:
https://review.coreboot.org/c/coreboot/+/81016/comment/7fb0733a_6db0bff8 : PS1, Line 26: 413 1 e 14 iommu This is a northbridge option, so this would better fit under the northbridge section below. Bit 436 appears to be the next free bit there.
https://review.coreboot.org/c/coreboot/+/81016/comment/085d081b_5aa838f7 : PS1, Line 76: 14 0 Disable : 14 1 Enable Enum 1 can be reused
File src/mainboard/lenovo/m900_tiny/cmos.layout:
https://review.coreboot.org/c/coreboot/+/81016/comment/eb64097e_27600e12 : PS1, Line 28: 412 411 is the next available bit
https://review.coreboot.org/c/coreboot/+/81016/comment/0637d564_541e60af : PS1, Line 60: 8 0 Disable : 8 1 Enable Enum 1 can be reused
File src/mainboard/supermicro/x10slm-f/cmos.layout:
https://review.coreboot.org/c/coreboot/+/81016/comment/000ab18e_f98c5f9e : PS1, Line 25: 412 Bit 411 is the next available bit
https://review.coreboot.org/c/coreboot/+/81016/comment/a3c6e62d_3e80ebdb : PS1, Line 61: 6 0 Disable : 6 1 Enable Enum 1 can be reused