caveh jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38165 )
Change subject: soc/intel/tigerlake: Enable VT-d and generate DMAR ACPI table
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38165/10/src/soc/intel/tigerlake/ac...
File src/soc/intel/tigerlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/38165/10/src/soc/intel/tigerlake/ac...
PS10, Line 198: struct device *const
did you mean
const struct device *?
const struct device *const
would also be OK.
same with ipu_dev.
https://review.coreboot.org/c/coreboot/+/38165/10/src/soc/intel/tigerlake/ac...
PS10, Line 243: 4
do we have a constant for the number of TCSS ports?
maybe add to tigerlake/chip.h?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38165
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib89d0835385487735c63062a084794d9da19605e
Gerrit-Change-Number: 38165
Gerrit-PatchSet: 10
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-CC: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Thu, 05 Mar 2020 03:28:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment