Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74113 )
Change subject: mb/google/myst: Configure WLAN ......................................................................
Patch Set 9:
(4 comments)
File src/mainboard/google/myst/variants/baseboard/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74113/comment/d6b57cf0_e33245d8 PS9, Line 5: romstage-y += gpio.c nit: Move above `ramstage` to match previous boards.
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/74113/comment/89b1c136_e07dd161 PS9, Line 193: static const struct soc_amd_gpio early_gpio_table[] = { Where did these GPIO values come from?
https://review.coreboot.org/c/coreboot/+/74113/comment/1ed592b6_b5599752 PS9, Line 202: pcie_gpio_table Skyrim defines this as `romstage_gpio_table`, which is used in `baseboard_romstage_gpio_table()`.
Why is this changed for Myst?
https://review.coreboot.org/c/coreboot/+/74113/comment/00e3807e_67ca639d PS9, Line 228: __weak void variant_pcie_gpio_table(const struct soc_amd_gpio **gpio, size_t *size) This isn't defined for any other board. It's also not called anywhere.
This should likely be `baseboard_romstage_gpio_table()`.