29 Nov
2022
29 Nov
'22
4:40 p.m.
Attention is currently required from: Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70162 )
Change subject: mb/google/herobrine: Only retrieve sku_id from EC once ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/herobrine/boardid.c:
https://review.coreboot.org/c/coreboot/+/70162/comment/0b591732_fd0bf3d7 PS2, Line 28: printk(BIOS_INFO, "BoardID :%d - "
Can we get rid of this too?
Ok, I removed it. Qualcomm, if you need this to stay in for some reason, please let us know.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70162
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia787968100baf58a41ccce0cf95ed3ec9ce1758a
Gerrit-Change-Number: 70162
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen shchen@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Sudheer Amrabadi samrabad@codeaurora.org
Gerrit-CC: Venkat Thogaru thogaru@qualcomm.corp-partner.google.com
Gerrit-CC: mturney mturney mturney@codeaurora.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Wed, 30 Nov 2022 00:40:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment